Skip to content

Improve reliability of session timeout spec #8676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Jun 29, 2023
Merged

Improve reliability of session timeout spec #8676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/features/saml/ial1_sso_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,23 +71,23 @@
end

it 'after session timeout, signing in takes user back to SP', :js, allow_browser_log: true do
allow(IdentityConfig.store).to receive(:session_check_delay).and_return(0)

user = create(:user, :fully_registered)
request_url = saml_authn_request_url

visit request_url
sp_request_id = ServiceProviderRequestProxy.last.uuid
allow(IdentityConfig.store).to receive(:session_check_delay).and_return(0)
allow(IdentityConfig.store).to receive(:session_check_frequency).and_return(1)
fill_in_credentials_and_submit(user.email, user.password)

Warden.on_next_request do |proxy|
proxy.env['devise.skip_trackable'] = true
session = proxy.env['rack.session']
session['warden.user.user.session']['last_request_at'] = 30.minutes.ago.to_i
end

expect(page).to have_current_path(new_user_session_path(request_id: sp_request_id), wait: 5)
allow(IdentityConfig.store).to receive(:session_check_delay).and_call_original
allow(IdentityConfig.store).to receive(:session_check_frequency).and_call_original

fill_in_credentials_and_submit(user.email, user.password)
fill_in_code_with_last_phone_otp
Expand Down