LG-9934 Prevent suspended user from reset password#8673
Merged
ThatSpaceGuy merged 7 commits intomainfrom Jul 5, 2023
Merged
Conversation
n1zyy
approved these changes
Jun 28, 2023
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I agree with Mitchell that this deserves a changelog entry, but otherwise, this looks good to me.
I keep wanting to suggest writing something to the log if a suspended account tries to reset their password in case we're asked to troubleshoot why someone isn't getting the emails, but we could get that just by looking at the user status, so I don't think it's necessary. 
ThatSpaceGuy
force-pushed
the
LG-9934-prevent-reset-password
branch
from
a6eaa9d to
bcdb6d1
Compare
ThatSpaceGuy
commented
Jul 5, 2023
Contributor
Author
|
@zachmargolis, I'm just curious whether you see anything that I might have missed about adding a new email to the project. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip changelog]
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-9934