Refactor WebAuthn verification to webauthn package#8665
Merged
Conversation
aduth
changed the title
aduth
force-pushed
the
aduth-refactor-webauthn-verify
branch
from
b0ff7a2 to
f613a25
Compare
zachmargolis
approved these changes
Jun 28, 2023
changelog: Internal, Code Quality, Consolidate WebAuthn code
aduth
force-pushed
the
aduth-refactor-webauthn-verify
branch
from
f613a25 to
05a67b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Related to LG-9873
🛠 Summary of changes
Refactors and moves code related to WebAuthn credential verification to the
@18f/identity-webauthnpackage.Similar to #8650. Extracted from #8639.
Why?
app/javascript/appfolderNote that the approach here was to try to simplify the diff for the current usage ahead of revisions slated for #8639. Specifically, passing
credentialIdsas a comma-separated string is not the ideal interface, but doing so helps simplify the diff, and this is slated to be changed in #8639.📜 Testing Plan
Ensure no regressions in signing in with Face or Touch Unlock or Security Key.
Check that
yarn testpasses.