Skip to content

Add contributing guidelines for code review #8646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 4 commits into from
Jun 23, 2023
Merged

Add contributing guidelines for code review #8646

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b57ebc2
Add contributing guidelines for code review
aduth Jun 22, 2023
475088a
Use org-qualified name for team
aduth Jun 23, 2023
3ee47c6
Fix typo
aduth Jun 23, 2023
84eb64a
Add instructions on joining interest group team
aduth Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,15 @@ reading.
- Once a pull request is good to go, the person who opened it squashes related
commits together, merges it, then deletes the branch.

Everyone is encouraged to participate in code review. To solicit feedback from specific people,
consider adding individuals or groups as requested reviewers on your pull request. Most internal
product teams have a team handle which can be used to notify everyone on that team, or you can
request reviews from one of the available interest group teams:

- `18f/identity-frontend` for developers interested in frontend development

To request to join any of these teams, you can contact any existing member and ask to be added.

## Public domain

This project is in the public domain within the United States, and
Expand Down