Add tests to cover password resets with a pending profile#8628
Merged
Conversation
We have uncovered a number of bugs that occur when a user with a pending profile resets their password. This commit adds tests to cover this behavior and make sure everything works as expected. Currently if a user with a pending profile resets their profile we deactivate their profile and it is unrecoverable. These tests may need to change if we give users the option to recover these profiles. [skip changelog]
mitchellhenke
approved these changes
Jun 21, 2023
Contributor
|
I arrived here after noticing we have two separate feature spec files which test password reset with a pending profile. Should they be consolidated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have uncovered a number of bugs that occur when a user with a pending profile resets their password. This commit adds tests to cover this behavior and make sure everything works as expected.
Currently if a user with a pending profile resets their profile we deactivate their profile and it is unrecoverable. These tests may need to change if we give users the option to recover these profiles.