Skip to content

Upgrade jsbundling-rails to skip unnecessary Yarn install#8623

Merged
aduth merged 6 commits intomainfrom
aduth-jsbundling-skip-install
Jun 21, 2023
Merged

Upgrade jsbundling-rails to skip unnecessary Yarn install#8623
aduth merged 6 commits intomainfrom
aduth-jsbundling-skip-install

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jun 20, 2023

🛠 Summary of changes

Upgrades jsbundling-rails to the latest version to use new feature allowing us to skip an extra yarn install, which is unnecessary in both CI and deployment, since we already install by that point. This should hopefully speed things up slightly.

if [ "$IDP_LOCAL_DEPENDENCIES" == "true" ]
then
bundle install --jobs 4 --local
yarn install --production --frozen-lockfile --offline --cache-folder .yarn-cache
else
bundle install --jobs 4
yarn install --production --frozen-lockfile --cache-folder .yarn-cache
fi

- *yarn_install
- bundle exec rake assets:precompile

identity-idp/.gitlab-ci.yml

Lines 192 to 193 in 2cf06f7

- *yarn_production_install
- bundle exec rake assets:precompile

Release notes: https://github.com/rails/jsbundling-rails/releases/tag/v1.1.2

Feature pull request: rails/jsbundling-rails#150

📜 Testing Plan

  • GitLab build should pass
  • Test in deployed environment (Edit: Done)

@aduth aduth marked this pull request as ready for review June 21, 2023 15:17
@aduth
Copy link
Contributor Author

aduth commented Jun 21, 2023

I tested this in my personal sandbox.

@aduth aduth merged commit 09a804b into main Jun 21, 2023
@aduth aduth deleted the aduth-jsbundling-skip-install branch June 21, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants