Upgrade jsbundling-rails to skip unnecessary Yarn install#8623
Merged
Conversation
mitchellhenke
approved these changes
Jun 20, 2023
…nuous integration builds
Contributor
Author
|
I tested this in my personal sandbox. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Upgrades
jsbundling-railsto the latest version to use new feature allowing us to skip an extrayarn install, which is unnecessary in both CI and deployment, since we already install by that point. This should hopefully speed things up slightly.identity-idp/deploy/build
Lines 27 to 34 in 2cf06f7
identity-idp/.gitlab-ci.yml
Lines 86 to 87 in 2cf06f7
identity-idp/.gitlab-ci.yml
Lines 192 to 193 in 2cf06f7
Release notes: https://github.com/rails/jsbundling-rails/releases/tag/v1.1.2
Feature pull request: rails/jsbundling-rails#150
📜 Testing Plan