LG-9810 Activating Profiles should be Atomic#8592
Merged
Conversation
changelog: Internal, IdV Profile States, Add transactions around all out activate profile methods
matthinz
reviewed
Jun 13, 2023
Contributor
matthinz
left a comment
matthinz
left a comment
There was a problem hiding this comment.
Could we get tests for these methods? Maybe monkeypatch User.activate to raise, call each method, and verify that the fields are not changed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9810
🛠 Summary of changes
Wrapped all of our profile activate methods into transactions to make them atomic. This way if there are any errors when activate is called it will rollback to the previous state before the change.