Skip to content

Fix specs that are broken on main #8583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 2 commits into from
Jun 12, 2023
Merged

Fix specs that are broken on main #8583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b3a0f9
Revert "Use fixed argument to travel_to rather than Time.zone.now (#8…
soniaconnolly Jun 12, 2023
fbe19a2
Add RSpec.describe instead of describe
soniaconnolly Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions spec/features/account_reset/delete_account_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
let(:user) { create(:user, :fully_registered) }
let(:user_email) { user.email_addresses.first.email }
let(:push_notification_url) { 'http://localhost/push_notifications' }
let(:frozen_now) { Time.zone.local(2023, 'jun', 9, 9, 0) }

let(:service_provider) do
create(
Expand Down Expand Up @@ -51,7 +50,7 @@

reset_email

travel_to(frozen_now + 2.days + 1) do
travel_to(Time.zone.now + 2.days + 1) do
AccountReset::GrantRequestsAndSendEmails.new.perform(Time.zone.today)
open_last_email
click_email_link_matching(/delete_account\?token/)
Expand Down Expand Up @@ -122,7 +121,7 @@
reset_email

allow(IdentityConfig.store).to receive(:push_notifications_enabled).and_return(true)
travel_to(frozen_now + 2.days + 1) do
travel_to(2.days.from_now + 1) do
request = stub_push_notification_request(
sp_push_notification_endpoint: push_notification_url,
event_type: PushNotification::AccountPurgedEvent::EVENT_TYPE,
Expand Down Expand Up @@ -235,7 +234,7 @@
expect(events.count).to eq received_event_types.count
expect(received_event_types).to match_array(expected_event_types)

travel_to(frozen_now + 2.days + 1.second) do
travel_to(Time.zone.now + 2.days + 1.second) do
AccountReset::GrantRequestsAndSendEmails.new.perform(Time.zone.today)
open_last_email
click_email_link_matching(/delete_account\?token/)
Expand Down
2 changes: 1 addition & 1 deletion spec/features/visitors/email_language_preference_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require 'rails_helper'

describe 'visitor signs up with email language preference' do
RSpec.describe 'visitor signs up with email language preference' do
it 'defaults to the current locale' do
visit sign_up_email_path

Expand Down