Conversation
app/javascript/packages/document-capture/components/review-issues-step.tsx
Show resolved
Hide resolved
svalexander
requested review from
a team and
WheresHJ
and removed request for
a team
|
@WheresHJ want to check w/ design about the ui. This doesn't look exactly like the figma as there's additional messaging about the error here that is separate from the variant text. |
| ).to.equal( | ||
| 'https://example.com/?step=document_capture&location=document_capture_troubleshooting_options', | ||
| ); | ||
| ).to.equal('https://example.com/?step=document_capture&location=post_submission_warning'); |
There was a problem hiding this comment.
this component has a default location value of document_capture_troubleshooting_options but the location value passed to the component in review_issues_step.tsx is post_submission_warning.
app/javascript/packages/document-capture/components/review-issues-step.tsx
Show resolved
Hide resolved
|
Looks good, Shannon! |
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Left one minor comment, but otherwise LGTM 👍
| return ( | ||
| <Warning | ||
| heading={t('errors.doc_auth.throttled_heading')} | ||
| actionText={t('idv.failure.button.warning_variant')} |
There was a problem hiding this comment.
Should this key still be called a "variant", or should it be the default?
I think we can't just remove the suffix, since the "Try again" plain text key is used for other things, but maybe we'd want to have a totally new key for the default IPP "Try again online" text.
| actionText={t('idv.failure.button.warning_variant')} | |
| actionText={t('in_person_proofing.cta.button.try_online)} |
tomas-nava
left a comment
tomas-nava
left a comment
There was a problem hiding this comment.
approve! good to merge once you've addressed Andrew's comment
5 participants
🎫 Ticket
LG-8332
🛠 Summary of changes
Make variation a (for the ipp cta) the default view for all users.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
For security reasons, you have %{count} attempts remaining to add your ID online.)events.logand verifyFrontend: IdV: IPP CTA Variant Displayedevent logs variant a.👀 Screenshots
Error page showing variation A