Skip to content

Jmax/lg 9296 updates to phone rate limit screen#8547

Merged
jmax-gsa merged 21 commits intomainfrom
jmax/LG-9296-updates-to-phone-rate-limit-screen
Aug 1, 2023
Merged

Jmax/lg 9296 updates to phone rate limit screen#8547
jmax-gsa merged 21 commits intomainfrom
jmax/LG-9296-updates-to-phone-rate-limit-screen

Conversation

@jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Jun 7, 2023

🎫 Ticket

LG-9296

🛠 Summary of changes

Updated the content and layout of the phone rate-limited screen.

Provide a checklist of steps to confirm the changes.

  • Bring up the app and begin identity verification. Proceed until phone verification.
  • Repeat phone verification until the app rate-limits you.
  • Verify that the phone rate-limited screen matches the Figma and translations from the ticket.

Figma
Translations

👀 Screenshots

Before:

before

After:

after

@jmax-gsa jmax-gsa force-pushed the jmax/LG-9296-updates-to-phone-rate-limit-screen branch 4 times, most recently from cf2d74b to de9d62e Compare June 9, 2023 14:22
@jmax-gsa jmax-gsa marked this pull request as ready for review June 9, 2023 14:36
@jmax-gsa jmax-gsa requested a review from a team June 9, 2023 14:36
@jmax-gsa jmax-gsa force-pushed the jmax/LG-9296-updates-to-phone-rate-limit-screen branch 3 times, most recently from a1e5b55 to 87849a0 Compare June 28, 2023 16:31
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. The ticket specifies that that link should return to the SP, not just cancel IdV. Seems weird to me too, but.

Copy link
Contributor

@amirbey amirbey Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right ... i'll guess you'll have to add some conditional logic based up presence of sp to determine the link destination (perhaps cancel Idv if sp not present)... but ultimately using the PagesFooterCompoenent will achieve the intended styling 👍🏿

<%= render PageFooterComponent.new do %>
<%= link_to t('links.cancel'), idv_cancel_path %>
<% end %>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @benjaminchait 👋🏿 .... in regards to the "Cancel" link at the bottom of the page ... when clicked, should the user simply be routed to the SP page (similar to the behavior of the "Exit and return to [SP]" links) or should the Cancel link actually cancel the current Idv in progress?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirbey - I believe the "Cancel" link should bring a user into the same experience we offer on other screens during IDV, which I think should look something like this:
Cancel as in canceling the current IDV in progress, correct?
Screenshot 2023-07-24 at 10 47 26 AM

Copy link
Contributor Author

@jmax-gsa jmax-gsa Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirbey, @benjaminchait - I fully agree with this statement, but I must point out that this is not what the ticket and UX materials specify.
They say that the user should be returned to the SP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per standup 16th minute conversation, @benjaminchait says this should not return to the SP, but rather to the usual screen for canceling IdV. UX team concurs.
Changed to point at idv_cancel_path

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bullet to insert here: Cancel and start over again after x hours

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. The ticket specifies that that link should return to the SP, not just cancel IdV. Seems weird to me too, but.

@jmax-gsa jmax-gsa force-pushed the jmax/LG-9296-updates-to-phone-rate-limit-screen branch from 87849a0 to 0fc21b2 Compare June 30, 2023 16:52
@jmax-gsa jmax-gsa force-pushed the jmax/LG-9296-updates-to-phone-rate-limit-screen branch from 0fc21b2 to 3d69441 Compare July 12, 2023 15:34
@jmax-gsa jmax-gsa force-pushed the jmax/LG-9296-updates-to-phone-rate-limit-screen branch from 7eacc37 to e237467 Compare July 14, 2023 15:31
@jmax-gsa jmax-gsa requested a review from amirbey July 14, 2023 17:06
Copy link
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jmax-gsa ! 👍🏿

Can you please add a feature test for the cancel button to verify it's reaching the correct destination?

Added a feature spec to make sure that canceling IdV from the
throttled phone page takes you to the correct page.
@jmax-gsa jmax-gsa merged commit 4d5f58f into main Aug 1, 2023
@jmax-gsa jmax-gsa deleted the jmax/LG-9296-updates-to-phone-rate-limit-screen branch August 1, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants