LG-10014 [Bugfix] Password Reset Activates Any Profile#8537
Merged
Conversation
New helper method will do proper checks to ensure that profile can actually be activated changelog: Bug Fixes, Profiles, Password reset profile activation bugfix
soniaconnolly
approved these changes
Jun 5, 2023
app/models/profile.rb
Outdated
|
|
||
| def activate_after_password_reset | ||
| update!( | ||
| deactivation_reason: nil, |
Contributor
There was a problem hiding this comment.
Should we check here thatdeactivation_reason is password_reset before removing it?
theabrad
approved these changes
Jun 5, 2023
zachmargolis
reviewed
Jun 5, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
can we get some regression spec coverage for this?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10014
🛠 Summary of changes
Previously, any password reactivation was manually setting the profile to
activein the database. This is a problem if the profile also has fraud and/or gpo pending. These changes include a new helper that uses the existingactivatemethod which does the appropriate checks for all pending/deactivation reasons first.