Merged
Conversation
changelog: Bug Fixes, IdV personal key, allow profiles to reach personal key step from confirm_profile_has_been_created
soniaconnolly
approved these changes
Jun 5, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM! Tried it out, works as described.
zachmargolis
approved these changes
Jun 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9858
🛠 Summary of changes
Users who were going through the verify-by mail flow and had a pending profile due to either fraud_review, or in-person proofing were not reaching the personal key step after they entered in their one-time code. The problem was that our before_action,
:confirm_profile_has_been_createdin the personal_key_controller was only looking at active profiles and not pending profiles also. Since the user is in a new session idv_session did not have the profile.📜 Testing Plan
Provide a checklist of steps to confirm the changes.