LG-9714 - Remove feature flag for password confirmation#8526
Merged
Conversation
jc-gsa
changed the title
changelog: Internal, Registration, Remove feature flag related to password confirmation
jc-gsa
force-pushed
the
LG-9714-remove-feature-flag
branch
from
7cac87e to
883b5c9
Compare
aduth
approved these changes
Jun 2, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
One minor clean-up remark, but LGTM otherwise 👍
mdiarra3
approved these changes
Jun 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9714
🛠 Summary of changes
This code removes something like a "feature flag" for the password confirmation feature that was implemented to ensure backwards compatibility across servers. Now that the servers are running the new code, the "feature flag" can be removed.
📜 Testing Plan
The easiest way to test that everything is working as expected is to sign up and create a new account. After submitting the "Create a strong password" form validations should be performed and it should be possible to create an account.