Swap identity-react-i18n for identity-i18n#8522
Merged
allthesignals merged 1 commit intomainfrom Jun 1, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
🛠 Summary of changes
Changes the i18n package for the address-search component.
Before, it was using an i18n wrapper package that enables the use of a React Context.
Now, it is using a lower-level i18n package that simply leverages the window object, which will make usage of it more straightforward outside of the context of identity-idp, specifically identity-site.
Note that these two i18n packages appear to be used interchangeably throughout. I am open to pushback on this! Currently, I'm spot-checking the level of effect to simply use the Context pattern inside the identity-site.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.