Merged
Conversation
Contributor
|
I agree that we should change how |
After trying to go to link_sent
eric-gade
approved these changes
Jun 1, 2023
When UploadStep or HybridHandoff have already been completed. This is for the 50/50 state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9975
🛠 Summary of changes
We eventually want the hybrid handoff step to be reentrant. For now, replicate the behavior of the FSM and redirect the user if the step is already complete. Use flow_path to indicate whether the step is complete.
Note: There are some complications because the analytics expect flow_path to be set on :show. We may want to just change that expectation and not set flow_path on show, which would simplify this PR considerably.