Merged
Conversation
added 2 commits
May 31, 2023 16:52
In #8475, we chose to keep Postgres at version 13 so that it could [match production](https://github.com/18F/identity-devops/blob/33ba02736b37f3a79c50479892a03c6f3e920041/terraform/app/rds-variables.tf#L82). However, when trying to continue on the `postgis` work, I found that when installing `postgis`, `brew` installs 14 anyway, as a dependency of `postgis`. There doesn't seem to be an easy way to tell Brew not to install 14, or postgis to use 13 instead. This becomes an issue then when the app is using 13, but `postgis` is using 14. I thought it'd be better to change this now than wait for the postgis work to be ready, as it would potentially stop folks from installing an extra version of postgres. There may be another workaround, but after reading [a homebrew issue about versioning issues with postgres and postgis](Homebrew/homebrew-core#86709), which included suggestions like [making your own copy of `postgis` and changing its dependencies](Homebrew/homebrew-core#86709 (comment)), it seemed like upgrading `postgres` was a better solution. While it will mean dev is on a different version than prod, most folks have been using 14 or even 15, so we don't expect issues to arise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
In #8475, we chose to keep Postgres at version 13 so that it could
match production.
However, when trying to continue on the
postgiswork, I found thatwhen installing
postgis,brewinstalls 14 anyway, as a dependency ofpostgis. There doesn't seem to be an easy way to tell Brew not toinstall 14, or postgis to use 13 instead. This becomes an issue then
when the app is using 13, but
postgisis using 14.I thought it'd be better to change this now than wait for the postgis
work to be ready, as it would potentially stop folks from installing an
extra version of postgres.
There may be another workaround, but after reading a homebrew issue
about versioning issues with postgres and postgis, which included
suggestions like making your own copy of
postgisand changing itsdependencies, it seemed like upgrading
postgreswas abetter solution.
While it will mean dev is on a different version than prod, most folks
have been using 14 or even 15, so we don't expect issues to arise.