Fix NoMethodError on unexpected response from USPS API#8513
Merged
tomas-nava merged 1 commit intomainfrom May 31, 2023
Merged
Conversation
changelog: Bug Fixes, In-person proofing, Fix NoMethodError on unexpected response from USPS
tomas-nava
force-pushed
the
tomas/fix-no-method-error-on-unexpected-request-enroll-response
branch
from
aaa6d43 to
a436fff
Compare
zachmargolis
approved these changes
May 31, 2023
NavaTim
approved these changes
May 31, 2023
tomas-nava
deleted the
tomas/fix-no-method-error-on-unexpected-request-enroll-response
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We encountered a case where a
NoMethodErrorwas being raised upon receiving a response from USPS API in an unexpected format. The error came from a case where we were using[variable].class.class_nameinstead of[variable].class.name.class_nameis a method provided by the yard gem that apparently is not available in production.