Skip to content

Remove styles associated with numeric input fields#8506

Merged
aduth merged 1 commit intomainfrom
aduth-rm-input-number-styles
May 30, 2023
Merged

Remove styles associated with numeric input fields#8506
aduth merged 1 commit intomainfrom
aduth-rm-input-number-styles

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented May 30, 2023

🛠 Summary of changes

Removes styles associated with [type="number"] input fields (see MDN documentation).

Why?

  • To the best of my knowledge, there are no [type="number"] fields in the application
  • Reduce size of application stylesheet to improve performance
  • Improve maintainability by...
    • Eliminating styles where the intended impact is unclear
    • Aligning closer to design system defaults

We could reintroduce in the future if the need arises, but I think it's worth a reevaluation anyways, and we'd want to scope it to specific instances (e.g. via component stylesheet).

Related resources:

📜 Testing Plan

There should be no user-facing impact of these changes.

changelog: Internal, Performance, Reduce size of application stylesheet in critical path
@aduth aduth merged commit 3af5161 into main May 30, 2023
@aduth aduth deleted the aduth-rm-input-number-styles branch May 30, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants