Remove styles associated with numeric input fields#8506
Merged
Conversation
changelog: Internal, Performance, Reduce size of application stylesheet in critical path
mitchellhenke
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes styles associated with
[type="number"]input fields (see MDN documentation).Why?
[type="number"]fields in the applicationWe could reintroduce in the future if the need arises, but I think it's worth a reevaluation anyways, and we'd want to scope it to specific instances (e.g. via component stylesheet).
Related resources:
📜 Testing Plan
There should be no user-facing impact of these changes.