Skip to content

Remove DocumentCaptureController direct usage of effective_user#8505

Merged
amirbey merged 11 commits intomainfrom
amirbey/LG-9856-idv-session-user
Jun 1, 2023
Merged

Remove DocumentCaptureController direct usage of effective_user#8505
amirbey merged 11 commits intomainfrom
amirbey/LG-9856-idv-session-user

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented May 30, 2023

🎫 Ticket

LG-9856

🛠 Summary of changes

  • IdvSession concern to use default to current_user when present and fallback to effective_user (as needed SessionErrorsController and CancellationsController).
  • Replace effective_user with current_user in StepUtilitiesConcern since all controllers using this concern have current_user.

@amirbey amirbey changed the title IdvSession to user current_user by default and effective user when cu… IdvSession Concern to default to current user when present in controller May 30, 2023
@amirbey amirbey self-assigned this May 30, 2023
@amirbey amirbey requested a review from a team May 30, 2023 17:11
@amirbey amirbey marked this pull request as ready for review May 30, 2023 17:11
@amirbey amirbey changed the title IdvSession Concern to default to current user when present in controller Remove DocumentCaptureController's direct usage of effective_user May 30, 2023
@amirbey amirbey changed the title Remove DocumentCaptureController's direct usage of effective_user Remove DocumentCaptureController direct usage of effective_user May 30, 2023
@amirbey amirbey requested a review from matthinz May 30, 2023 22:48
@amirbey amirbey requested a review from soniaconnolly June 1, 2023 14:39
Copy link
Contributor

@matthinz matthinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amirbey amirbey merged commit 27b91b7 into main Jun 1, 2023
@amirbey amirbey deleted the amirbey/LG-9856-idv-session-user branch June 1, 2023 19:17
This was referenced Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants