Configure Stylelint to report needless disables#8504
Merged
Conversation
changelog: Internal, Static Analysis, Improve stylesheet linting to report unnecessary inline configuration
zachmargolis
approved these changes
May 30, 2023
mitchellhenke
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates Stylelint configuration to report needless inline configuration for disabling rules, to avoid misleading developers with ineffective configuration.
I considered adding this to the
@18f/identity-stylelint-configcommon configuration, but since it's a breaking change, it'd be best to wait to group it with some other breaking change for the package.📜 Testing Plan
yarn lint:csspasses.