Remove 404 action from HybridHandoff controller#8500
Merged
Conversation
kbighorse
changed the title
kbighorse
force-pushed
the
LG-9786-remove-404-from-hybrid-handoff
branch
from
a5aa217 to
f9af448
Compare
kbighorse
added
status - do not merge
status - blocked
and removed
status - do not merge
status - blocked
labels
kbighorse
requested review from
jmhooper and
soniaconnolly
and removed request for
jmhooper and
soniaconnolly
soniaconnolly
approved these changes
May 30, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM
And I found a couple of bugs that need to be fixed before we can merge this.
soniaconnolly
approved these changes
May 30, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM
And I found a couple of bugs that need to be fixed before we can merge this.
kbighorse
force-pushed
the
LG-9786-remove-404-from-hybrid-handoff
branch
from
f9af448 to
ed0dd11
Compare
…4 on hybrid handoff
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: User-Facing Improvements, Identity Verification, Remove 404 on hybrid handoff
🎫 Ticket
Remove 404 action from HybridHandoff controller
🛠 Summary of changes
Removes
before_actionand method that renders a 404 based on hybrid handoff controller enabled.