Skip to content

Add BadgeComponent for design system badges#8491

Merged
aduth merged 2 commits intomainfrom
aduth-badge-component
May 30, 2023
Merged

Add BadgeComponent for design system badges#8491
aduth merged 2 commits intomainfrom
aduth-badge-component

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented May 26, 2023

🎫 Ticket

Supports future work LG-9953 and implementation for LG-8872.

🛠 Summary of changes

Refactors badge UI partials as view component.

Why?

  • Support future usage and options planned between LG-9953 and implementation for LG-8872
  • Improve coverage of component preview demonstrating available components
  • Reduce chance for human error with ad hoc implementations
  • Improve performance in critical paths by reducing size of main application stylesheet

📜 Testing Plan

Confirm existing usage:

  1. Go to http://localhost:3000
  2. Set up an account with an unphishable MFA (security key, face & touch unlock, PIV)
  3. Once on account dashboard, observe no regressions in display of "Unphishable" badge

Confirm component preview:

  1. Go to http://localhost:3000/components/inspect/badge/preview

changelog: Internal, Components, Refactor badges as reusable UI component
@aduth
Copy link
Contributor Author

aduth commented May 26, 2023

FYSA @nickttng (this will add badges to component previews)

@aduth aduth requested a review from a team May 30, 2023 14:27
Copy link
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@aduth aduth merged commit 62ce9ab into main May 30, 2023
@aduth aduth deleted the aduth-badge-component branch May 30, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants