Updating how gpo pending is set in dummy profile#8434
Merged
tomas-nava merged 2 commits intomainfrom May 18, 2023
Merged
Conversation
mitchellhenke
approved these changes
May 18, 2023
n1zyy
approved these changes
May 18, 2023
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
Fixes the issue for me! Thanks for jumping on this!
theabrad
approved these changes
May 18, 2023
dawei-nava
pushed a commit
that referenced
this pull request
May 18, 2023
* Updating how gpo pending is set in dummy profile * changelog [skip changelog]
dawei-nava
added a commit
that referenced
this pull request
May 18, 2023
* LG-8349: Move AddressSearch component into own package changelog: Internal, Code Structure, separate AddressSearch UI component as package. * LG-8439: remove old component. * LG-8439: package information. * LG-8439: change log file. * LG-8439: address comments * Update app/javascript/packages/address-search/README.md Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com> * Update app/javascript/packages/address-search/index-spec.tsx Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com> * LG-8439: extra / not needed. * Add support for per-component stylesheets (#8375) * Add support for per-component stylesheets changelog: Internal, Optimization, Reduce size of stylesheet assets for critical path * Forward required to use uswds-core conventionally * Override _uswds-core via internal load path * Remove unnecessary load path * Prioritize `--load-path` flag in Sass load path resolution * Add specs for component stylesheets * Add specs for StylesheetHelper * Rename clipboard component stylesheet to simple scss * Render stylesheet_once_tags everywhere application is rendered * Fix component preview for per-component stylesheet * LG-8439: resolve conflict * LG-8439: address comments * Updating how gpo pending is set in dummy profile (#8434) * Updating how gpo pending is set in dummy profile * changelog [skip changelog] --------- Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Eric Gade <105373963+eric-gade@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a test failure that was introduced to main from a recent merged PR. The issue was to do with how user profiles for GPO pending states are now determined (using a timestamp). CI did not catch this because the PR branch was not rebased on main prior to merge, and there were no other conflicts.