Refactor handling of successful two-factor phone confirmation#8424
Merged
mitchellhenke merged 2 commits intomainfrom May 18, 2023
Merged
Refactor handling of successful two-factor phone confirmation#8424mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
changelog: Internal, Two-Factor Authentication, Refactor handling of successful two-factor phone confirmation
zachmargolis
approved these changes
May 18, 2023
app/controllers/two_factor_authentication/otp_verification_controller.rb
Outdated
Show resolved
Hide resolved
…troller.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
A small follow-up to #8347 to move some phone-specific functionality out of
TwoFactorAuthenticationMethods. The path is a little bit circuitous with callinghandle_valid_otpand aconfirmationstate inUserSessionContext, but thetrack_mfa_method_addedmethod defined is only used when confirming a phone. The big clue is that the method name sounds general, but turns out to be specific to confirming a phone.This PR pulls that method definition into the
OtpVerificationControllerand calls it when confirming a phone.