Skip to content

LG-9726 Use the fraud review checker in the place of fraud_review_eligible #8408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 2 commits into from
May 17, 2023
Merged

LG-9726 Use the fraud review checker in the place of fraud_review_eligible #8408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1170af
LG-9726 Use the fraud review checker in the place of fraud_review_eli…
jmhooper May 16, 2023
e3b4387
spelling
jmhooper May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/models/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,6 @@ def gpo_verification_pending_profile
profiles.where.not(gpo_verification_pending_at: nil).order(created_at: :desc).first
end

def fraud_review_eligible?
fraud_review_pending_profile&.fraud_review_pending_at&.after?(30.days.ago)
end

def fraud_review_pending?
fraud_review_pending_profile.present?
end
Expand Down
4 changes: 2 additions & 2 deletions lib/tasks/review_profile.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace :users do
next
end

if user.fraud_review_eligible?
if FraudReviewChecker.new(user).fraud_review_eligible?
profile = user.fraud_review_pending_profile
profile.activate_after_passing_review

Expand Down Expand Up @@ -73,7 +73,7 @@ namespace :users do
next
end

if user.fraud_review_eligible?
if FraudReviewChecker.new(user).fraud_review_eligible?
profile = user.fraud_review_pending_profile

profile.reject_for_fraud(notify_user: true)
Expand Down
41 changes: 0 additions & 41 deletions spec/models/user_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,47 +529,6 @@
end
end

describe '#fraud_review_eligible?' do
context 'when fraud_review_pending_at is nil' do
it 'returns false' do
fraud_review_pending_at = nil

user = create(:user)
user.profiles.create(
fraud_review_pending_at: fraud_review_pending_at,
)

expect(user.fraud_review_eligible?).to be_falsey
end
end

context 'when verified_at is within 30 days' do
it 'returns true' do
fraud_review_pending_at = 15.days.ago

user = create(:user)
user.profiles.create(
fraud_review_pending_at: fraud_review_pending_at,
)

expect(user.fraud_review_eligible?).to eq true
end
end

context 'when verified_at is older than 30 days' do
it 'returns false' do
fraud_review_pending_at = 45.days.ago

user = create(:user)
user.profiles.create(
fraud_review_pending_at: fraud_review_pending_at,
)

expect(user.fraud_review_eligible?).to eq false
end
end
end

describe '#fraud_review_pending?' do
it 'returns true if fraud review is pending' do
user = create(:user)
Expand Down