Skip to content

LG-9570 Remove LinkSentController 404 action #8383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amirbey merged 3 commits into from
May 12, 2023
Merged

LG-9570 Remove LinkSentController 404 action #8383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58fbac6
remove 404 action form LinkSentController
May 11, 2023
d3ed817
remove 404 status test
May 11, 2023
6d53e01
[skip changelog]
May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/controllers/idv/link_sent_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ class LinkSentController < ApplicationController
include StepIndicatorConcern
include StepUtilitiesConcern

before_action :render_404_if_link_sent_controller_disabled
before_action :confirm_two_factor_authenticated
before_action :confirm_upload_step_complete
before_action :confirm_document_capture_needed
Expand Down Expand Up @@ -43,10 +42,6 @@ def extra_view_variables

private

def render_404_if_link_sent_controller_disabled
render_not_found unless IdentityConfig.store.doc_auth_link_sent_controller_enabled
end

def confirm_upload_step_complete
return if flow_session['Idv::Steps::UploadStep']

Expand Down
8 changes: 0 additions & 8 deletions spec/controllers/idv/link_sent_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,4 @@
end
end
end

context 'feature flag disabled' do
let(:feature_flag_enabled) { false }
it 'returns a 404' do
get :show
expect(response.status).to eql(404)
end
end
end