Skip to content

Fix flaky data-pull tests by truncating timestamps #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 2 commits into from
May 9, 2023
Merged

Fix flaky data-pull tests by truncating timestamps #8366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed46316
Fix flaky tests by truncating timestamps
zachmargolis May 9, 2023
c3c10d4
Switch to more flexible type matcher because timestamps will always d…
zachmargolis May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/data_pull.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def run(args:, include_missing:)

users.each do |user|
user.email_addresses.sort_by(&:id).each do |email_address|
table << [user.uuid, email_address.email, email_address.confirmed_at.round(6)]
table << [user.uuid, email_address.email, email_address.confirmed_at]
end
end

Expand Down
4 changes: 2 additions & 2 deletions spec/lib/data_pull_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,11 @@
subject(:result) { subtask.run(args:, include_missing:) }

it 'loads email addresses for the user' do
expect(result.table).to eq(
expect(result.table).to match(
[
['uuid', 'email', 'confirmed_at'],
*user.email_addresses.sort_by(&:id).map do |e|
[e.user.uuid, e.email, e.confirmed_at.round(6)]
[e.user.uuid, e.email, kind_of(Time)]
end,
['does-not-exist', '[NOT FOUND]', nil],
],
Expand Down