LG-9439: Verify info controller refactor#8356
Merged
tomas-nava merged 6 commits intomainfrom May 8, 2023
Merged
Conversation
added 3 commits
May 8, 2023 07:39
changelog: Internal, Refactor, Refactor verify info controllers
JackRyan1989
reviewed
May 8, 2023
…info-controller-refactor
|
|
||
| private | ||
|
|
||
| def confirm_ssn_step_complete |
Contributor
There was a problem hiding this comment.
We've been putting these methods that check flow state into IdvStepConcern. I think that would be a better place for confirm_ssn_step_complete.
It's more debatable for delete_pii, but we have pii_from_doc in there, so it could move too. We're eventually going to consolidate the flow_session code and use idv_session.
Contributor
Author
There was a problem hiding this comment.
Thank you! I moved confirm_ssn_step_complete into IdvStepConcern in 47914a6
I think I'll leave delete_pii where it is, because it's only used by move_applicant_to_idv_session, also in the Idv::VerifyInfoConcern.
soniaconnolly
approved these changes
May 8, 2023
and make it and all the other 'confirm' before methods private
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9439
🛠 Summary of changes
Moves methods shared by the two verify info controllers into the shared
VerifyInfoConcern, refactors theInPerson::VerifyInfoControllerto use theIdvStepConcernimplementation ofconfirm_verify_info_step_needed.