Fix Sign In tabbed A/B variant after LGDS 7#8354
Merged
Conversation
[skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes a visual regression introduced in #8093, affecting one of the 3 Sign-In page A/B test variants ("Tabbed"). Fortunately, the design system upgrade has not shipped yet in production, so the bug is not live.
#8093 takes advantage of USWDS' new per-component stylesheet optimization feature, opting in to only the components currently in use. Because of overlapping timeframe of #8093 and #8112 and the fact that the A/B test is not shown in all cases, the "Button Group" component was not included.
I also made another pass at trying to find components potentially in use that are not included, and did not find others.
📜 Testing Plan
Easier to test when forcing Tabbed variant 100% of the time, adding this to
config/application.yml:👀 Screenshots