Fix mobile navigation to prevent horizontal scroll#8352
Merged
Conversation
changelog: Bug Fixes, Account Navigation, Fix horizontal scroll for mobile navigation
aduth
commented
May 5, 2023
aduth
commented
May 5, 2023
| <button | ||
| type="button" | ||
| aria-label={t('users.personal_key.close')} | ||
| aria-label={t('account.navigation.close')} |
Contributor
Author
There was a problem hiding this comment.
This should probably have its own translation key, so we don't run into similar future issues like here where we're referencing personal key long after the personal key modal has been removed.
matthinz
approved these changes
May 5, 2023
Contributor
matthinz
left a comment
matthinz
left a comment
There was a problem hiding this comment.
LGTM and agree about the i18n key.
mitchellhenke
approved these changes
May 5, 2023
Contributor
Author
I'll plan to do a quick follow-on for this so that I can make sure this fix lands in tomorrow's release. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an issue where the mobile navigation on the account dashboard unintentionally allows horizontal scroll, when only vertical scrolling is expected. This is due to the markup not aligning to the documented code for the component.
👀 Screenshots
Before:
RPReplay_Final1683316026.MP4
After:
RPReplay_Final1683315995.MP4