Add default load paths support for build-sass#8346
Merged
Conversation
So that it can be used across packages, and in published packages
aduth
commented
May 5, 2023
changelog: Internal, Build Tooling, Improve Sass compilation tool to support defaults for design system
Contributor
Author
|
Published to NPM as |
aduth
added a commit
to GSA-TTS/identity-site
that referenced
this pull request
May 8, 2023
Why? - As verification that the improvements implemented in 18F/identity-idp#8346 are valid when used in an external project - To give developers implementing by copy-paste reference a good reference to copy from
Merged
aduth
added a commit
to GSA-TTS/identity-site
that referenced
this pull request
Jun 26, 2023
Why? - As verification that the improvements implemented in 18F/identity-idp#8346 are valid when used in an external project - To give developers implementing by copy-paste reference a good reference to copy from
aduth
added a commit
to GSA-TTS/identity-site
that referenced
this pull request
Jun 26, 2023
* Upgrade 18f/identity-build-sass to 1.2.0 Why? - As verification that the improvements implemented in 18F/identity-idp#8346 are valid when used in an external project - To give developers implementing by copy-paste reference a good reference to copy from * Bump build-sass to 1.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Enhances the
@18f/identity-build-sassutility package to automatically provide default load paths for supported packages@18f/identity-design-systemand@uswds/uswds. This is consistent with the package's goal of providing "smart defaults", and prevents consuming projects needing to include an additional--load-pathflag when using the CLI.📜 Testing Plan
yarn build:cssshould produce no errors with included changes to remove the now-unnecessary--load-pathflag.