LG-9515: Refactor capture_secondary_id_enabled

[night-jellyfish]

🎫 Ticket

LG-9515

🛠 Summary of changes

Refactored the capture_secondary_id_enabled method to be defined once

Because these classes all inherit from DocAuthBaseStep and define the
method in the exact same way, we can DRY it up by removing the method
from the descendant classes.

📜 Testing Plan

with capture_secondary_id_enabled

• enable in_person_capture_secondary_id_enabled
• follow the flow to the State ID step
• note that the radio button for same address as id is on the State ID page, as is the initial address entry
• follow through to the verify page
• expect that underneath the Verify your information heading, you see subheadings of State-issued ID, Residential address, and Social Security Number

without capture_secondary_id_enabled

• disable in_person_capture_secondary_id_enabled
• follow the flow past the State ID step to the address step
• note that the radio button for same address as id is on the Address page
• follow through to the verify page
• expect the only heading to be Verify your information

[aduth]

Will In-Person Proofing be moving away from FlowStateMachine (the "step" implementations) like what is currently happening with Unsupervised Proofing? If it were, maybe it'd be better to move the common behavior into a concern/mixin rather than the base step, which would be more portable to a controller once DocAuthBaseStep goes away.

[JackRyan1989]

@aduth that's a really good call out. We are planning on making that change in the future, though we have a ways to go. Since it's a single method, I'm not sure it makes sense to create a new mixin/concern to house it at this exact moment, but I don't have a strong opinion.

[tomas-nava]

Will In-Person Proofing be moving away from FlowStateMachine (the "step" implementations) like what is currently happening with Unsupervised Proofing? If it were, maybe it'd be better to move the common behavior into a concern/mixin rather than the base step, which would be more portable to a controller once DocAuthBaseStep goes away.

We are planning to move these pages out of the FSM at the same time they're being consolidated into a single-page form, in LG-9443 and related tickets. That's a major refactor so I think it's fine to wait until then to worry about where this method lives.

[svalexander]

LGTM. It's nice to be able to delete stuff!

[JackRyan1989]

LGTM!