LG-9663 Move prepare page before location page in IPP flow - functional changes only by JackRyan1989 · Pull Request #8308 · 18F/identity-idp

JackRyan1989 · 2023-04-28T21:09:27Z

🎫 Ticket

🛠 Summary of changes

The prepare page now appears before the location page in the IPP flow. Changes made to React application and RSpec feature tests where necessary.

📜 Testing Plan

Confirm that the Prepare Page is visited before the Location page in the IPP flow
Confirm that you can navigate back to the Prepare Page from the Location Page
Confirm that the Location Page navigates to the State ID step on submit

👀 Screenshots - see PR 8312

…step ahead of Location step in IPP flow

...vascript/packages/document-capture/components/in-person-location-post-office-search-step.tsx

…-move-prepare-page-before-location

config/locales/in_person_proofing/es.yml

app/javascript/packages/form-steps/form-steps.tsx

carmenrosalop · 2023-05-02T18:13:17Z

@JackRyan1989 could you please update the screen shots? it seems like the version in Spanish for the PO search doesn't show the updates

JackRyan1989 · 2023-05-02T18:27:24Z

@JackRyan1989 could you please update the screen shots? it seems like the version in Spanish for the PO search doesn't show the updates

@carmenrosalop can you please check in the content changes only Pull Request? I'm sorry for the confusion!

…-move-prepare-page-before-location

kellular

Jack walked me through the updated flow. LGTM!

NavaTim · 2023-05-03T20:12:35Z

app/javascript/packages/document-capture/components/in-person-prepare-step.tsx

      {flowPath === 'hybrid' && <FormStepsButton.Continue />}
      {inPersonURL && flowPath === 'standard' && (
        <div className="margin-y-5">
-          <SpinnerButton onClick={onContinue} isBig isWide>
+          <SpinnerButton type="submit" onClick={onContinue} isBig isWide>
            {t('forms.buttons.continue')}
          </SpinnerButton>


Are we able to simplify this logic and use FormStepsButton.Continue for both cases, esp. now that this page will not direct the user outside the flow?

I think so. I have some changes that reduce the complexity here.

Updated @NavaTim

NavaTim · 2023-05-03T20:14:43Z

...vascript/packages/document-capture/components/in-person-location-post-office-search-step.tsx

+            trackEvent('IdV: location submitted', {
+              selected_location: selectedLocationAddress,
+              in_person_cta_variant: inPersonCtaVariantActive,
+            });
+            forceRedirect(inPersonURL!);


What's the behavior of these trackEvent and forceRedirect calls during hybrid flow?

Good q. So trackEvent could get called twice, once on the typical submission event and then here at line 77. And then the forceRedirect behavior is probably being overridden.

Options: I could wrap the trackEvent and forceRedirect in an if check analogous to what I do for the event.preventDefault; or I could try to take advantage of the e.click() behavior that pre-existed my changes.

I opted for wrapping the forceRedirect trackEvent calls in an if check @NavaTim

…-move-prepare-page-before-location

allthesignals · 2023-05-05T15:21:07Z

...vascript/packages/document-capture/components/in-person-location-post-office-search-step.tsx

+      if (flowPath !== 'hybrid') {
+        e.preventDefault();
+      }


Is this related to what we were seeing in the hybrid test failures? Unsure what this is needed for.

Yeah, so as far as I can tell this is the one change that was breaking that test. I need to do more digging, but my understanding of the React FSM is that it's listening for submit events specifically. We were preventing that and then doing a click, so I think that was it.

allthesignals

I'm wondering what was the source of our testing woes with the hybrid flow? I see a new check for the hybrid flowPath... seems related.

Thanks for shepherding this through! Looks great.

allthesignals · 2023-05-05T15:21:53Z

...vascript/packages/document-capture/components/in-person-location-post-office-search-step.tsx

+                selected_location: selectedLocationAddress,
+                in_person_cta_variant: inPersonCtaVariantActive,
+              });
+              forceRedirect(inPersonURL!);


Ah, was this the helper you mentioned earlier?

Um, I don't think so as Tomas was the one who added this bit in. I think I was referring to const [, setStepName] = useHistoryParam(undefined);

allthesignals · 2023-05-05T15:26:55Z

app/javascript/packages/document-capture/components/in-person-prepare-step.tsx

+      {inPersonURL && flowPath === 'standard' ? (
+        <FormStepsButton.Continue className="margin-y-5" />
+      ) : (
+        <FormStepsButton.Continue />


…-move-prepare-page-before-location

jack-ryan-nava-pbc added 3 commits April 28, 2023 16:55

content updates, minor refactors and tests

fbce6d0

Whacking with linter

6debd20

changelog: User-facing improvements, In-person Proofing, Put Prepare …

7b1d9d8

…step ahead of Location step in IPP flow

JackRyan1989 requested review from a team April 28, 2023 21:09

JackRyan1989 self-assigned this Apr 28, 2023

JackRyan1989 requested review from NavaTim and rutvigupta-design and removed request for a team April 28, 2023 21:09

JackRyan1989 mentioned this pull request Apr 28, 2023

LG-8948: Swap order of form steps "Location" and "Prepare" #8125

Closed

1 task

kellular requested review from kellular and removed request for rutvigupta-design April 28, 2023 21:22

Fix verify info spec presentation order

427f765

aduth reviewed May 1, 2023

View reviewed changes

...vascript/packages/document-capture/components/in-person-location-post-office-search-step.tsx Outdated Show resolved Hide resolved

jack-ryan-nava-pbc added 3 commits May 1, 2023 14:57

Merge branch 'main' of github.com:18F/identity-idp into jryan/lg-8948…

5419e34

…-move-prepare-page-before-location

get rid of dirty ternary

599cf3a

Updating specs

ae30a8a

soniaconnolly reviewed May 1, 2023

View reviewed changes

config/locales/in_person_proofing/es.yml Show resolved Hide resolved

aduth reviewed May 2, 2023

View reviewed changes

app/javascript/packages/form-steps/form-steps.tsx Outdated Show resolved Hide resolved

JackRyan1989 changed the title ~~LG 8948 Move prepare page before location page in IPP flow~~ LG-9663 Move prepare page before location page in IPP flow - functional changes only May 2, 2023

remove unnecessary else statement

6fa61a3

carmenrosalop requested review from carmenrosalop and removed request for kellular May 2, 2023 18:10

carmenrosalop requested review from kellular and removed request for carmenrosalop May 2, 2023 18:54

jack-ryan-nava-pbc added 3 commits May 3, 2023 10:39

Merge branch 'main' of github.com:18F/identity-idp into jryan/lg-8948…

d8e65fa

…-move-prepare-page-before-location

use fsm for prepare step

607e114

appeasing linter

e76720e

kellular approved these changes May 3, 2023

View reviewed changes

NavaTim reviewed May 3, 2023

View reviewed changes

jack-ryan-nava-pbc added 5 commits May 4, 2023 13:50

adding prepare submit event to analytics and addressing tims questions

6eddae3

add back in space

7ed29d3

Merge branch 'main' of github.com:18F/identity-idp into jryan/lg-8948…

d08e591

…-move-prepare-page-before-location

fix ordering of prepare and location steps in spec

fc9c1ca

remove unnecessary useRef call

a6754e7

allthesignals reviewed May 5, 2023

View reviewed changes

allthesignals approved these changes May 5, 2023

View reviewed changes

jack-ryan-nava-pbc added 2 commits May 5, 2023 13:03

Merge branch 'main' of github.com:18F/identity-idp into jryan/lg-8948…

9de64b1

…-move-prepare-page-before-location

update page order in spec

11394b6

JackRyan1989 merged commit 572b64a into main May 5, 2023

JackRyan1989 deleted the jryan/lg-8948-move-prepare-page-before-location branch May 5, 2023 18:32

soniaconnolly mentioned this pull request May 8, 2023

Deploy RC 278 to Prod #8360

Merged

Conversation

JackRyan1989 commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

📜 Testing Plan

👀 Screenshots - see PR 8312

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carmenrosalop commented May 2, 2023

Uh oh!

JackRyan1989 commented May 2, 2023

Uh oh!

kellular left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allthesignals left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JackRyan1989 commented Apr 28, 2023 •

edited

Loading