Skip to content

LG-9334: Clean up Funnel::DocAuth::RegisterStep #8272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solipet merged 5 commits into from
Apr 28, 2023
Merged

LG-9334: Clean up Funnel::DocAuth::RegisterStep #8272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7508bc5
LG-9334: Clean up Funnel::DocAuth::RegisterStep
solipet Apr 21, 2023
2ec5bdb
restore ruby patch version
solipet Apr 26, 2023
5ba3c09
restore `link_sent` from RegisterStep's token allowlist
solipet Apr 26, 2023
63ad4cf
keep the ignored columns for now and tell rubocop to not worry
solipet Apr 26, 2023
611a0f4
restored link_sent columms precision/default
solipet Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/models/doc_auth_log.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ class DocAuthLog < ApplicationRecord
primary_key: 'issuer'
# rubocop:enable Rails/InverseOf

# rubocop:disable Rails/UnusedIgnoredColumns
self.ignored_columns = [
:email_sent_view_at,
:email_sent_view_count,
:send_link_view_at,
:send_link_view_count,
]
# rubocop:enable Rails/UnusedIgnoredColumns
end
10 changes: 10 additions & 0 deletions db/primary_migrate/20230425164533_remove_unused_doc_auth_logs_columns.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
class RemoveUnusedDocAuthLogsColumns < ActiveRecord::Migration[7.0]
def change
safety_assured do
remove_column :doc_auth_logs, :send_link_view_at, :datetime
remove_column :doc_auth_logs, :send_link_view_count, :integer
remove_column :doc_auth_logs, :email_sent_view_at, :datetime
remove_column :doc_auth_logs, :email_sent_view_count, :integer
end
end
end
6 changes: 1 addition & 5 deletions db/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema[7.0].define(version: 2023_04_19_190148) do
ActiveRecord::Schema[7.0].define(version: 2023_04_25_164533) do
# These are extensions that must be enabled in order to support this database
enable_extension "pg_stat_statements"
enable_extension "pgcrypto"
Expand Down Expand Up @@ -99,12 +99,8 @@
t.integer "welcome_view_count", default: 0
t.datetime "upload_view_at", precision: nil
t.integer "upload_view_count", default: 0
t.datetime "send_link_view_at", precision: nil
t.integer "send_link_view_count", default: 0
t.datetime "link_sent_view_at", precision: nil
t.integer "link_sent_view_count", default: 0
t.datetime "email_sent_view_at", precision: nil
t.integer "email_sent_view_count", default: 0
t.datetime "front_image_view_at", precision: nil
t.integer "front_image_view_count", default: 0
t.integer "front_image_submit_count", default: 0
Expand Down