Log completed SAML Remote Logout requests#8261
Merged
mitchellhenke merged 3 commits intomainfrom Apr 24, 2023
Merged
Conversation
changelog: Internal, Logging, Log completed SAML Remote Logout requests
Jeremy1026
reviewed
Apr 24, 2023
| # Service provider completed remote logout | ||
| # @param [String] service_provider | ||
| # @param [String] user_id | ||
| def remote_logout_completed( |
Contributor
There was a problem hiding this comment.
Is this worth adding a test for?
Sgtpluck
reviewed
Apr 24, 2023
| session_id = ServiceProviderIdentity. | ||
| find_by(user_id: user_id, service_provider: saml_request.issuer). | ||
| rails_session_id | ||
| where(user_id: user_id, service_provider: saml_request.issuer).pick(:rails_session_id) |
Contributor
There was a problem hiding this comment.
[question] is saml_request.issuer different from the issuer passed in?
Contributor
Author
There was a problem hiding this comment.
whoops, it should be, but I intended to replace saml_request.issuer with the argument passed to the function
Sgtpluck
approved these changes
Apr 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
To better understand the impact of remote logout on the user experience, this PR adds a log event for when a user's session is deleted from Redis (though it may already be expired).