-
Notifications
You must be signed in to change notification settings - Fork 167
LG-9215: Implement A/B test for adding a banner to account creation page #8250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
ef47c52
create an account banner partial, refactor banner
jmdembe dacb24b
change banner to not show on default
jmdembe f7f66ee
add config value, setup for view
jmdembe 75ab242
toggle show based on page location
jmdembe bd0dbfd
add test bucket and add analytic to user registration event
jmdembe e6dd5ce
Merge branch 'main' into LG-9215-ab-test-account-creation
jmdembe 23c1adc
address PR comment, rename variable, fix logic
jmdembe cdbe8fd
right wrongs that I had created
jmdembe 80d7ade
add/edit analytics
jmdembe c6dcd1c
remove urlhelper
jmdembe e0e2d03
revert changes made for account banner ab test
jmdembe 11f154e
merge create an account banner w/ sign in a/b test
jmdembe cd6d825
Merge branch 'main' into LG-9215-ab-test-account-creation
jmdembe dea3b72
remove config value
jmdembe 0249988
lint fixes, cleanup for create account banner
jmdembe a737614
modify header of create an account banner
jmdembe bd76cdc
make heading a banner instead
jmdembe c610d2c
WIP: modify banner for a11y best practices
jmdembe 1bbc64f
WIP: page title on sign in page
jmdembe 296b7eb
Merge branch 'main' into LG-9215-ab-test-account-creation
jmdembe 3073be0
add banner variable to ab test
jmdembe fec4374
make adjustment to base c-a-b container
jmdembe cc01cae
Merge branch 'main' into LG-9215-ab-test-account-creation
jmdembe 33c3c14
add test for banner test
jmdembe bcc4034
remove binding, show banner after switching between languages
jmdembe 8b1ef40
Address PR comment: make `@is_home_page` true
jmdembe 909d222
fix: 100 percent on default instead of banner
jmdembe 3499881
rename to `create_account_banner`
jmdembe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <h2 class='separator-text'> | ||
| <%= t('headings.create_account_with_sp.cta', app_name: APP_NAME) %> | ||
| </h2> | ||
| <%= render ButtonComponent.new( | ||
| action: ->(**tag_options, &block) { link_to(sign_up_email_url(source: :sign_in), **tag_options, &block) }, | ||
| big: true, | ||
| outline: true, | ||
| full_width: true, | ||
| class: 'margin-bottom-105', | ||
| ).with_content(t('links.create_account')) %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.