Conversation
theabrad
reviewed
Apr 20, 2023
theabrad
reviewed
Apr 20, 2023
Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
jskinne3
suggested changes
Apr 27, 2023
Co-authored-by: John Skiles Skinner <john.skinner@gsa.gov>
kbighorse
reviewed
May 3, 2023
| analytics.idv_please_call_visited | ||
| verified_at = current_user.profiles.last.verified_at || Time.zone.today | ||
| @call_by_date = verified_at + FRAUD_REVIEW_CONTACT_WITHIN_DAYS | ||
| pending_at = current_user.profiles.last.fraud_review_pending_at || Time.zone.today |
Contributor
There was a problem hiding this comment.
suggestion: we can use User#fraud_rejection_profile here instead of User#profiles.last
kbighorse
reviewed
May 3, 2023
|
|
||
| describe Idv::PleaseCallController do | ||
| let(:user) { create(:user) } | ||
| let(:fraud_review_pending_date) { 5.days.ago } |
Contributor
There was a problem hiding this comment.
comment: possibly note that this only needs to be non-null
jmax-gsa
deleted the
jmax/LG-9401-use-new-fraud-review-timestamp-for-sad-face-screen
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-9152
🛠 Summary of changes
Changed the message on the sad face screen to use the new fraud review timestamp, rather than the verified_at timestamp
📜 Testing Plan
Provide a checklist of steps to confirm the changes.