LG-9321: New field on Enrollment Outcomes for GetUspsProofingResultsJob Summary by gina-yamada · Pull Request #8216 · 18F/identity-idp

gina-yamada · 2023-04-14T19:28:27Z

🎫 Ticket

Note: This PR will be one of two to complete LG-9321.
The first pull request is PR#8216 in identity-idp. (THIS ONE)
The second pull request is PR#6078 in identity-devops.

🛠 Summary of changes

Calculate percentage of enrollments errored when enrollments exists
Add key/value to enrollment_outcomes,key=percent_enrollments_errored (to be consumed in identity-devops by my new HighErrorRate alarm, PR coming soon)
Update and add testing

📜 Testing Plan

Observe all passing tests- updated x1 test so it would pass after code change, added 2 additional tests
Observe new alarm HighErrorRate in Slack. This shows the new key/value was consumed as my alarm was hit
Observe newly created field and calculated value in AWS CloudWatch.

Sign in to AWS with aws-vault login sandbox-power
Go to CloudWatch
Go to Logs Insights
Pick joy_/srv/idp/shared/log/events.log as the log group
Update the query to be...
fields @timestamp, @message, @logStream, @log | filter name like "GetUspsProofingResultsJob: Job completed"
Select Custom (top right corner) and pick April 14, 2023 and then click Run query.
Open up the logs. All but the first (last in the list) will have properties.event_properties.percent_enrollments_errored listed with the correctly calculated percentage, (err/checked)*100.

👀 Screenshots

Before:

Field properties.event_properties.percent_enrollments_errored is not on summary.

After:

Field properties.event_properties.percent_enrollments_errored is on summary with the correctly calculated percentage.

…21-alert-for-errored-enrollments

…comes summary for GetUspsProofingResultsJob

gina-yamada · 2023-04-14T19:52:40Z

app/jobs/get_usps_proofing_results_job.rb

+          enrollment_outcomes[:enrollments_checked],
+        ) * 100).round
+    end
+


multiple lines to satisfy the linter

NavaTim

Looks good, I made a few suggestions to remove unused code and improve the alarm precision.

app/jobs/get_usps_proofing_results_job.rb

Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com>

racingspider

Looks good

* Remove unused configuration redis_throttle_alternate_url and redis_throttle_alternate_pool_write_enabled configurations (#8211) changelog: Internal, Configuration, Remove unused Redis migration configuration * Override tag style to leave case unchanged and make text bold (#8212) * Override tag style to leave case unchanged and make text bold Per Andrew Duthie the Login style for tags is Title case and bold, but the design system is still all caps, so override it for idp for now. changelog: User-facing Improvements, Design, change 'tag' style to be bold and preserve case * LG-9333 Preserve the SSN when returning to the SSN controller (#8197) The SSN controller allows a user to enter or update their SSN. Prior to this commit the previous value of the SSN was not maintained when the user was updating their SSN. This commit attempts to fix that by making use of the SSN form that is used in the controller. The template is changed to eventually read the SSN from the form. Additionally, the form is used in a pattern that better matches the pattern you expect a form object to be used in. This was not the case before because of constraints that the flow state machine placed on HTML forms. changelog: Improvements, Proofing workflow, The user's SSN is preserved for users who enter and SSN then continue to the verify step but return to the SSN in the unsupervised remote proofing flow. * LG-8714 Remove UserDecorator (#8204) * Moving UserDecorator methods to User * Updating all references to user.decorate Also: - Move UserDecorator specs to User spec (with adjustments) - Delete old UserDecorator class and spe Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Jskinne3 lg 9361 mobile local md (#8217) * Transfer mobile guide from old branch * Link to mobile docs from other docs * Check spelling * [skip changelog] * Auto-generate README * Soften USB hub wording becase it works for some people * Seperate mobile device and VM instructions * Configure the DDP mock client to respond with a failed result on `no_result` (#8214) In a previous commit we changed the DDP proofer to respond with an exception result when the result from DDP included an unexpected status (ref: #8149). This includes when the result is nil. This commit changes the DDP mock's behavior to align with the DDP proofer's behavior. [skip changelog] * LG-9034 Log TrueID decision product status (#8195) * LG-9034 Log TrueID decision product status Capture decision product status for TrueID responses Decision product status contains the result of TrueID after decisioning. Prior to this change, product status was only being captured for @productType='TrueID' and ignoring product status for @productType='TrueID_Decision' * [skip changelog] * successful if TrueID_Decision product does not exist * refactor obtaining decision_product for reuse * happy linting * Update spec/services/doc_auth/lexis_nexis/responses/true_id_response_spec.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * remove unnecessary expect statements since the check is done a few lines below * remove line no longer used in test --------- Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * LG-9488: Entry controller for hybrid mobile document capture flow (#8209) * Add placeholder CaptureDocController * Add controller to handle entry into hybrid flow Controller looks at `document-capture-session` and does a "light login" to enable the user to start document capture. changelog: Internal, Flow state machine removal, Add controller for entry into hybrid mobile document capture * Refactor feature flag check out to HybridMobileConcern * Add tests around the 'Doc Auth' event * Send links to new hybrid mobile experience Going with /verify/documents?document-capture-session=xxxxx as a temporary url for now * CaptureDocController -> DocumentCaptureController * Tweak doc capture entry url naming & add comment * idv_hybrid_mobile_document_capture_entry_url -> idv_hybrid_mobile_entry_url * Refactor EntryController not to use before_action * Move HybridMobileConcern into Idv::HybridMobile namespace * WHOOPS need to see why this wasn't breaking any tests * Remove extra redirect Rails doesn't preserve the querystring when redirecting routes, and this is just an unnecessary extra step anyway * Add feature spec for mobile hybrid flow entry * Tweaks to capture complete step spec Ultimately we'll merge this with a doc capture step, presumably * Fix email confirmation 500 (#8224) * add failing spec * Use strong parameters in email confirmation controller to fix 500 error changelog: Bug Fixes, Email Confirmation, Use strong parameters in email confirmation controller to fix 500 error * LG-9321: New field on Enrollment Outcomes for GetUspsProofingResultsJob Summary (#8216) * LG-9321 Add data to usps proof results job * LG-9321 Added one more test * LG-9321 Fix lint issues * changelog: Internal, In-person-proofing, new metric on enrollment outcomes summary for GetUspsProofingResultsJob * LG-9321 Add arg to round() for precision * LG-9321 Update round to have more precision Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com> * LG-9321 Remove initial unnecessary assignment Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com> --------- Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com> --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Eric Gade <105373963+eric-gade@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: John Skiles Skinner <john.skinner@gsa.gov> Co-authored-by: Amir Reavis-Bey <1261794+amirbey@users.noreply.github.com> Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> Co-authored-by: gina-yamada <125507397+gina-yamada@users.noreply.github.com> Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com>

…ob Summary (#8216) * LG-9321 Add data to usps proof results job * LG-9321 Added one more test * LG-9321 Fix lint issues * changelog: Internal, In-person-proofing, new metric on enrollment outcomes summary for GetUspsProofingResultsJob * LG-9321 Add arg to round() for precision * LG-9321 Update round to have more precision Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com> * LG-9321 Remove initial unnecessary assignment Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com> --------- Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com>

gina-yamada added 8 commits April 11, 2023 15:23

LG-9321 Add data to usps proof results job

ffaa2a4

Merge branch 'main' of github.com:18F/identity-idp into gyamada/LG-93…

92bdebb

…21-alert-for-errored-enrollments

Merge branch 'main' of github.com:18F/identity-idp into gyamada/LG-93…

624521d

…21-alert-for-errored-enrollments

Merge branch 'main' of github.com:18F/identity-idp into gyamada/LG-93…

caeef52

…21-alert-for-errored-enrollments

LG-9321 Added one more test

4187402

LG-9321 Fix lint issues

456522c

Merge branch 'main' of github.com:18F/identity-idp into gyamada/LG-93…

b3595a8

…21-alert-for-errored-enrollments

changelog: Internal, In-person-proofing, new metric on enrollment out…

518937b

…comes summary for GetUspsProofingResultsJob

gina-yamada requested review from a team and racingspider April 14, 2023 19:45

gina-yamada commented Apr 14, 2023

View reviewed changes

NavaTim approved these changes Apr 14, 2023

View reviewed changes

app/jobs/get_usps_proofing_results_job.rb Outdated Show resolved Hide resolved

app/jobs/get_usps_proofing_results_job.rb Outdated Show resolved Hide resolved

gina-yamada and others added 3 commits April 14, 2023 14:54

LG-9321 Add arg to round() for precision

4bee7c9

LG-9321 Update round to have more precision

6242648

Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com>

LG-9321 Remove initial unnecessary assignment

82c9d02

Co-authored-by: Tim Bradley <90272033+NavaTim@users.noreply.github.com>

racingspider approved these changes Apr 17, 2023

View reviewed changes

gina-yamada merged commit b78bb4c into main Apr 17, 2023

gina-yamada deleted the gyamada/LG-9321-alert-for-errored-enrollments branch April 17, 2023 20:03

jmdembe mentioned this pull request Apr 18, 2023

Deploy RC 273 to Production #8230

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-9321: New field on Enrollment Outcomes for GetUspsProofingResultsJob Summary#8216

LG-9321: New field on Enrollment Outcomes for GetUspsProofingResultsJob Summary#8216
gina-yamada merged 11 commits intomainfrom
gyamada/LG-9321-alert-for-errored-enrollments

gina-yamada commented Apr 14, 2023 •

edited

Loading

Uh oh!

gina-yamada Apr 14, 2023

Uh oh!

NavaTim left a comment

Uh oh!

Uh oh!

Uh oh!

racingspider left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gina-yamada commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

📜 Testing Plan

👀 Screenshots

Uh oh!

gina-yamada Apr 14, 2023

Choose a reason for hiding this comment

Uh oh!

NavaTim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

racingspider left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gina-yamada commented Apr 14, 2023 •

edited

Loading