Fix incorrect SAML path being called in SAML POST authentication#8182
Merged
mitchellhenke merged 6 commits intomainfrom Apr 12, 2023
Merged
Fix incorrect SAML path being called in SAML POST authentication#8182mitchellhenke merged 6 commits intomainfrom
mitchellhenke merged 6 commits intomainfrom
Conversation
julialeague
approved these changes
Apr 11, 2023
mitchellhenke
force-pushed
the
mitchellhenke/fix-saml-postauth-bug
branch
from
5d503a0 to
f1600b2
Compare
zachmargolis
approved these changes
Apr 11, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
whoops, thanks for fixing
changelog: Bug Fixes, SAML, Fix incorrect SAML path being called in SAML POST authentication Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/fix-saml-postauth-bug
branch
from
bf924c5 to
bf22eca
Compare
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/fix-saml-postauth-bug
branch
from
370a3f9 to
05e2346
Compare
Contributor
|
This inspired me to bring back this old PR which I think has the same net benefit: #7153 |
Merged
jc-gsa
pushed a commit
that referenced
this pull request
Apr 19, 2023
* Fix incorrect SAML path being called in SAML POST authentication changelog: Bug Fixes, SAML, Fix incorrect SAML path being called in SAML POST authentication Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * add failing spec * Update config/application.yml.default Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * fix specs * fix specs --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes issue we ran into with #8166 where the path changed years to the first year, rather than the originally requested one.