Allow accessibility tests to be skipped#815
Conversation
There was a problem hiding this comment.
I like this tagging method. Might also make sense to include something in all of these accessibility specs that auto-includes this tag (and :js) so people don't need to remember to add this if/when future accessibility specs are added
There was a problem hiding this comment.
That's a great idea, although I don't know how to do that without putting all accessibility tests in a single file. Do you know?
There was a problem hiding this comment.
What about changing the command line arguments to add --exclude-pattern "accessibility". That way as long as we keep the tests in the right directory we don't have to worry about tagging the tests?
There was a problem hiding this comment.
That's a good idea @zachmargolis -- I was just researching ways to programmatically add a flag to an example, but didn't find anything.
There was a problem hiding this comment.
Would it be helpful to tag the tests regardless, in case someone wants to only run the accessibility specs?
There was a problem hiding this comment.
Looks like it needs to be more specific: https://www.relishapp.com/rspec/rspec-core/v/3-5/docs/configuration/exclude-pattern
I'll play around with it.
There was a problem hiding this comment.
What did you try? Based on: https://www.relishapp.com/rspec/rspec-core/v/3-5/docs/configuration/exclude-pattern
I would expect this to work:
--exclude-pattern "**/features/accessibility/*_spec.rb"
There was a problem hiding this comment.
That's what I'm trying right now, @jessieay
There was a problem hiding this comment.
Please take another look at the latest changes.
Makefile
Outdated
There was a problem hiding this comment.
this is neat -- should we document it somewhere in the README?
monfresh
force-pushed
the
mb-tag-accessibility-specs
branch
from
b71148c to
55ad28e
Compare
**Why**: Because they take 24 seconds to run, and we don't need to check accessibility tests all the time when developing locally. **How**: Add a `fast_test` command to the Makefile that skips tests in the `accessibility` directory.
monfresh
force-pushed
the
mb-tag-accessibility-specs
branch
from
55ad28e to
1e513d0
Compare
**Why**: Because they take 24 seconds to run, and we don't need to check accessibility tests all the time when developing locally. **How**: Add a `fast_test` command to the Makefile that skips tests in the `accessibility` directory.
**Why**: Because they take 24 seconds to run, and we don't need to check accessibility tests all the time when developing locally. **How**: Add a `fast_test` command to the Makefile that skips tests in the `accessibility` directory.
3 participants
Why: Because they take 24 seconds to run, and we don't need to
check accessibility tests all the time when developing locally.
How: Add a
fast_testcommand to the Makefile that skips teststagged with
accessibility.