Skip to content

Fix error when verifying nil backup code #8148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 2 commits into from
Apr 6, 2023
Merged

Fix error when verifying nil backup code #8148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f898be4
Fix error when verifying nil backup code
Apr 6, 2023
130cdde
Update app/services/backup_code_generator.rb
Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/services/backup_code_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def create

# @return [Boolean]
def verify(plaintext_code)
return false unless plaintext_code.present?
backup_code = RandomPhrase.normalize(plaintext_code)
code = BackupCodeConfiguration.find_with_code(code: backup_code, user_id: @user.id)
return false unless code_usable?(code)
Expand Down
5 changes: 5 additions & 0 deletions spec/services/backup_code_generator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
expect(success).to eq false
end

it 'should reject nil codes' do
success = generator.verify(nil)
expect(success).to eq false
end

it 'creates codes with the same salt for that batch' do
generator.create

Expand Down