Skip to content

LG-9238: Test that state id jurisdiction is sent to aamva #8138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eileen-nava merged 3 commits into from
Apr 6, 2023
Merged

LG-9238: Test that state id jurisdiction is sent to aamva #8138

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b98ff8c
test that state id jurisdiction is sent to aamva
eileen-nava Apr 4, 2023
4a01f06
changelog: Internal, In-person proofing, test state id jurisdiction i…
eileen-nava Apr 5, 2023
c08bc88
refactor test to use nokogiri
eileen-nava Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions spec/services/proofing/aamva/request/verification_request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,15 @@

expect(result.success?).to eq(true)
end

it 'sends state id jurisdiction to AAMVA' do
applicant.state_id_data.state_id_jurisdiction = 'NY'
expect(
Nokogiri::XML(subject.body) do |config|
config.strict
end.text,
).to match(/NY/)
Comment on lines +109 to +113
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the goal of using an XML parser was likely also to navigate the XML struscture, so I'd recommend more like:

Suggested change
expect(
Nokogiri::XML(subject.body) do |config|
config.strict
end.text,
).to match(/NY/)
doc = Nokogiri::XML(subject.body) { |config| config.strict }
message_destination = doc.at_css('MessageDestinationId')
expect(message_destination.text).to eq('NY')

Copy link
Copy Markdown
Contributor Author

@eileen-nava eileen-nava Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, I merged my PR before seeing your comment. I'd modeled the change on the example you linked, which used match. Oops.

end
end

# rubocop:disable Layout/LineLength
Expand Down