Skip to content

Do not prompt for re-authentication on backup code refresh prompt #8134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 2 commits into from
Apr 5, 2023
Merged

Do not prompt for re-authentication on backup code refresh prompt #8134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9dff59
Do not prompt for re-authentication on backup code refresh prompt
Apr 4, 2023
f22cb20
fix spec
Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/users/backup_code_setup_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class BackupCodeSetupController < ApplicationController
before_action :set_backup_code_setup_presenter
before_action :apply_secure_headers_override
before_action :authorize_backup_code_disable, only: [:delete]
before_action :confirm_recently_authenticated_2fa, if: -> do
before_action :confirm_recently_authenticated_2fa, except: [:reminder], if: -> do
IdentityConfig.store.reauthentication_for_second_factor_management_enabled
end

Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/users/backup_code_setup_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
:authenticate_user!,
:confirm_user_authenticated_for_2fa_setup,
:apply_secure_headers_override,
:confirm_recently_authenticated_2fa,
[:confirm_recently_authenticated_2fa, except: ['reminder']],
)
end
end
Expand Down
4 changes: 1 addition & 3 deletions spec/support/matchers/have_actions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@ def parsed_only_action(action)
end

def parsed_except_action(action)
except_option = unless_option_for(action)[0]

"#{except_option.class}OptionParser".constantize.new(except_option).parse
unless_option_for(action)[0].instance_variable_get(:@actions).to_a
end

class ProcOptionParser
Expand Down