Skip to content

LG-9237: Send USPS the state instead of jurisdiction from state ID #8131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NavaTim merged 1 commit into from
Apr 6, 2023
Merged

LG-9237: Send USPS the state instead of jurisdiction from state ID #8131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/usps_in_person_proofing/enrollment_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def usps_proofer
state_id_address1: :address1,
state_id_address2: :address2,
state_id_city: :city,
state_id_jurisdiction: :state,
state_id_state: :state,
Copy link
Copy Markdown
Contributor

@eileen-nava eileen-nava Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

state_id_zipcode: :zipcode,
}.freeze

Expand Down
2 changes: 1 addition & 1 deletion spec/services/usps_in_person_proofing/enrollment_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
}",
city: Idp::Constants::MOCK_IDV_APPLICANT_STATE_ID_ADDRESS[:state_id_city],
state: Idp::Constants::MOCK_IDV_APPLICANT_STATE_ID_ADDRESS[
:state_id_jurisdiction
:state_id_state
],
Comment on lines 123 to 125
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Apr 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is short enough to fit on one line now rightj?

                  state: Idp::Constants::MOCK_IDV_APPLICANT_STATE_ID_ADDRESS[:state_id_state],

Copy link
Copy Markdown
Contributor Author

@NavaTim NavaTim Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably could go on one line, but I'll leave that up to the next person who updates this file.

zip_code: Idp::Constants::MOCK_IDV_APPLICANT_STATE_ID_ADDRESS[:state_id_zipcode],
)
Expand Down