Conversation
…esting to see if changing priority affects user selection
app/controllers/users/two_factor_authentication_setup_controller.rb
Outdated
Show resolved
Hide resolved
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Functionally works great 👍 Most comments are minor / stylistic.
spec/controllers/users/two_factor_authentication_setup_controller_spec.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Can you remind me why we have two different controllers for MFA setup? 🤔
There was a problem hiding this comment.
Ugh something I want to refactor, the mfa_selection controller is for the controller to select/add additional mfa methods after the prompt if a user selects a single MFA method on account creation. I think originally the mfa selection had a few extra things that were extra/annoying (showing/graying out already selected mfa method, as well as two factor authentication setup controller will redirect you to account page if you have one authentication method already). We can definitely make this a lot cleaner.
There was a problem hiding this comment.
Would you want to write a ticket summarizing the problem and maybe we can get that work prioritized?
* changelog: Upcoming Features, Authentication, Add capability for ab testing to see if changing priority affects user selection * add additional params to loggin params * add bucket * rubocop and other specs * fix linting * analytics events * fix up rspec * LG-9214: address comments * rubocop
4 participants
🎫 Ticket
Lg-9214
🛠 Summary of changes
Sets up MFA selection order test for A/B testing. add logging on buckets to query for the testing.