Jmax/lg 9147 show extra guidance for puerto rico addresses#8088
Merged
Jmax/lg 9147 show extra guidance for puerto rico addresses#8088
Conversation
aduth
reviewed
Mar 28, 2023
81f5cfb to
d73c5e2
Compare
aduth
reviewed
Apr 7, 2023
aduth
reviewed
Apr 17, 2023
app/views/idv/address/new.html.erb
Outdated
Contributor
There was a problem hiding this comment.
I think it may not be necessary to add this as a new standalone argument, since ValidatedFieldComponent passes through all additional options to SimpleForm. I think you could do something like this instead:
Suggested change
| hint_class: @presenter.hint_class, | |
| hint_html: { class: @presenter.hint_class }, |
Contributor
Author
There was a problem hiding this comment.
Tried this and ran into problems. It's a good idea, but not quite this straightforward.
Contributor
There was a problem hiding this comment.
Did you also remove the ValidatedFieldComponent revisions? I could imagine with those as implemented, the hint_html class would be overridden. But reverting those changes should work. #8232
[skip changelog]
Ensures that the text is present but hidden on initial rendering. The client-side JavaScript will show and hide it as appropriate.
Use Idv::AddressPresenter instead of faking it. Add handling for Puerto Rico specific hints for address1, addresss2, city, and zipcode fields.
e22c538 to
fa7e86e
Compare
jc-gsa
pushed a commit
that referenced
this pull request
Apr 19, 2023
The Puerto Rico information blurb and address field hints are present but hidden on initial rendering. The client-side JavaScript shows and hide it as appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎫 Ticket
LG-9147
🛠 Summary of changes
app/views/idv/address/new.html) to always render Puerto Rico address guidance as hidden text.📜 Testing Plan
👀 Screenshots