LG-9098 DocumentCaptureController#update, desktop flow, feature flagged#8074
Merged
soniaconnolly merged 10 commits intomainfrom Mar 27, 2023
Merged
LG-9098 DocumentCaptureController#update, desktop flow, feature flagged#8074soniaconnolly merged 10 commits intomainfrom
soniaconnolly merged 10 commits intomainfrom
Conversation
Co-authored-by: Eric Gade <eric.gade@gsa.gov>
Co-authored-by: Eric Gade <eric.gade@gsa.gov> Co-authored-by: Kimball Bighorse <kimball.bighorse@gsa.gov>
Check for the step in flow_session. Later we can add a property and methods to Idv::Session. changelog: Internal, Flow State Machine replacement, Add update method to DocumentCapture step
changelog: Internal, document capture, Add document capture update functionality outside flow state machine (feature flagged)
Add a method on Idv::Session to delete the applicant Reference current_user.id instead of user_id Include DocumentCaptureConcern to set Acuant Content Security Policy
Contributor
|
lgtm! I can also confirm that on a mobile device -- even with the feature flag set -- we are entering the FSM step instead as intended with this PR. |
eric-gade
approved these changes
Mar 27, 2023
jmhooper
approved these changes
Mar 27, 2023
Contributor
jmhooper
left a comment
jmhooper
left a comment
There was a problem hiding this comment.
This looks good to me. Always nice to have a short, easily reviewable diff!
Contributor
Author
I'm appreciating the way you split up the tickets! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9098
🛠 Summary of changes
Add code from existing DocumentCapture step to handle #update method in new DocumentCaptureController, for desktop flow only. The bulk of the document capture work is still done on the front end. Bring over feature tests and make them pass.
📜 Testing Plan
doc_auth_document_capture_controller_enabledfeature flag totruein local application.yml/verify/document_capture(going there automatically is a separate PR)👀 Screenshots
After: