Remove words, use only numbers in countdowns#807
Merged
Conversation
el-mapache
force-pushed
the
ab-ms-no-words
branch
from
00f066d to
a69a640
Compare
brendansudol
reviewed
Dec 2, 2016
Contributor
There was a problem hiding this comment.
could this be simplified to return minutes || 0;?
brendansudol
approved these changes
Dec 2, 2016
el-mapache
force-pushed
the
ab-ms-no-words
branch
from
a69a640 to
549327e
Compare
**Why**: Translating and formating complex time strings is going to be messy. Numbers should be sufficient for most users
amoose
pushed a commit
that referenced
this pull request
Feb 24, 2017
**Why**: Translating and formating complex time strings is going to be messy. Numbers should be sufficient for most users
amoose
pushed a commit
that referenced
this pull request
Feb 28, 2017
**Why**: Translating and formating complex time strings is going to be messy. Numbers should be sufficient for most users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Translating and formating complex time strings is going to be messy.
Numbers should be sufficient for most users