Rescue external server errors in location search controllers to avoid exceptions#8068
Merged
mitchellhenke merged 1 commit intomainfrom Mar 24, 2023
Conversation
aduth
approved these changes
Mar 24, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Should we just rescue the base Faraday::Error class, rather than incrementally adding each subclass?
mitchellhenke
force-pushed
the
mitchellhenke/rescue-faraday-errors-in-location-search
branch
from
6e94556 to
671cba3
Compare
Contributor
Author
Smart, yes we should. PR has been updated. |
mitchellhenke
force-pushed
the
mitchellhenke/rescue-faraday-errors-in-location-search
branch
from
671cba3 to
c2ce4b8
Compare
aduth
approved these changes
Mar 24, 2023
… exceptions changelog: Bug Fixes, In-person Proofing, Rescue external server errors to avoid exceptions
mitchellhenke
force-pushed
the
mitchellhenke/rescue-faraday-errors-in-location-search
branch
from
c2ce4b8 to
e210958
Compare
mitchellhenke
deleted the
mitchellhenke/rescue-faraday-errors-in-location-search
branch
mitchellhenke
pushed a commit
that referenced
this pull request
Mar 24, 2023
… exceptions (#8068) changelog: Bug Fixes, In-person Proofing, Rescue external server errors to avoid exceptions
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Similar to #8060 and #7894, this adds a more general class of errors to avoid returning exceptions on in these controllers.