Fix Content Security Policy errors when redirecting to service provider#8063
Merged
mitchellhenke merged 2 commits intomainfrom Mar 23, 2023
Merged
Conversation
jc-gsa
approved these changes
Mar 23, 2023
added 2 commits
March 23, 2023 16:27
changelog: Bug Fixes, Authentication, Fix Content Security Policy errors when redirecting to service provider
mitchellhenke
force-pushed
the
mitchellhenke/secure-headers-in-rules-of-use
branch
from
8699ece to
75b73b6
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
Mar 24, 2023
…er (#8063) * Fix Content Security Policy errors when redirecting to service provider changelog: Bug Fixes, Authentication, Fix Content Security Policy errors when redirecting to service provider * add failing spec
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Bug reported here where a user received a CSP error because we redirect back to the relying party in the chain of redirects from the Rules of Use submission request.
This adds the SP domain headers to the response to avoid this error case.